Skip to content

Conversation

@rubydong
Copy link
Collaborator

@rubydong rubydong commented Jul 2, 2025

Description

https://jira.mongodb.org/browse/CLOUDP-328862
When the screen is small, the insights button looks bad when expanded. I adjusted the breakpoint but only had it affect the icons in the documents tab since DropdownMenu is a reusable component used in other areas as well.

Before:

Screen.Recording.2025-07-02.at.5.58.42.PM.mov

After (Normal screen):
image

After (Resizing mode):

Screen.Recording.2025-07-03.at.10.37.46.AM.mov

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added
  • If this change updates the UI, screenshots/videos are added and a design review is requested
  • I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@github-actions github-actions bot added the feat label Jul 2, 2025
@rubydong rubydong added the no release notes Fix or feature not for release notes label Jul 2, 2025
@rubydong rubydong marked this pull request as ready for review July 2, 2025 22:02
@rubydong rubydong requested a review from a team as a code owner July 2, 2025 22:02
@rubydong rubydong added the no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) label Jul 2, 2025
@@ -0,0 +1 @@
export const DOCUMENT_NARROW_ICON_BREAKPOINT = '1264px'; // This is the width at which the icons switch to narrow mode in the Documents tab.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Might as use an actual doc comment here.

Suggested change
export const DOCUMENT_NARROW_ICON_BREAKPOINT = '1264px'; // This is the width at which the icons switch to narrow mode in the Documents tab.
/**
* The width at which the icons switch to narrow mode in the Documents tab
*/
export const DOCUMENT_NARROW_ICON_BREAKPOINT = '1264px';

@rubydong rubydong merged commit 4b26d6d into main Jul 3, 2025
54 of 57 checks passed
@rubydong rubydong deleted the cloudp-328862 branch July 3, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat no release notes Fix or feature not for release notes no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants