Skip to content

chore(data-modeling): move export state to redux and add telemetry COMPASS-9523 #7092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 4, 2025
Merged

chore(data-modeling): move export state to redux and add telemetry COMPASS-9523 #7092

merged 6 commits into from
Jul 4, 2025

Conversation

@mabaasit
Copy link
Collaborator

@mabaasit mabaasit commented Jul 4, 2025

Description

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added
  • If this change updates the UI, screenshots/videos are added and a design review is requested
  • I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

Copilot AI review requested due to automatic review settings July 4, 2025 07:14
@mabaasit mabaasit requested a review from a team as a code owner July 4, 2025 07:14
@mabaasit mabaasit added feature flagged PRs labeled with this label will not be included in the release notes of the next release no release notes Fix or feature not for release notes labels Jul 4, 2025
Copilot AI reviewed Jul 4, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

gribnoysup
gribnoysup reviewed Jul 4, 2025
View reviewed changes
packages/compass-data-modeling/src/store/export-diagram.ts Outdated
isExporting: false,
};

let cancelExportAbortController: AbortController | null = null;
Copy link
Collaborator

@gribnoysup gribnoysup Jul 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be scoped to the plugin store, not global, extra thunk arg is how we usually do this

Copy link
Collaborator Author

@mabaasit mabaasit Jul 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added in ae0d002

gribnoysup
gribnoysup approved these changes Jul 4, 2025
View reviewed changes
Copy link
Collaborator

@gribnoysup gribnoysup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One note on where to put the abort controller, but otherwise looks good, feel free to merge after updating this part

@mabaasit mabaasit merged commit abb53b2 into main Jul 4, 2025
57 of 58 checks passed
@mabaasit mabaasit deleted the COMPASS-9523-move-export-state-to-redux branch July 4, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@gribnoysup gribnoysup gribnoysup approved these changes

Assignees

No one assigned

Labels

feature flagged PRs labeled with this label will not be included in the release notes of the next release no release notes Fix or feature not for release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mabaasit @gribnoysup