Skip to content

chore(e2e-tests): skip j int test as it isn't recognized on CI #7105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2025
Merged

chore(e2e-tests): skip j int test as it isn't recognized on CI #7105

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbeb443
chore(e2e-tests): skip j int test as it isn't recognized on CI
Anemy Jul 10, 2025
4119d38
remove .only
Anemy Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/compass-e2e-tests/tests/data-modeling-tab.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,8 @@ describe('Data Modeling tab', function () {

expect(text).to.include('id objectId'.toLowerCase());
expect(text).to.include('i int');
expect(text).to.include('j int');
// Disabled as it's not recognized correctly by tesseract.js at the moment.
// expect(text).to.include('j int');
// it does not correctly recognize `iString` and only returns `String`.
Comment on lines +328 to 329
Copy link

Copilot AI Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a TODO or reference an issue ticket here to re-enable this assertion once Tesseract.js correctly recognizes 'j int', helping future maintainers track the fix.

Suggested change
// expect(text).to.include('j int');
// it does not correctly recognize `iString` and only returns `String`.
// TODO: Re-enable the following assertion once Tesseract.js correctly recognizes 'j int'.
// expect(text).to.include('j int');

Copilot uses AI. Check for mistakes.
// its already good enough to verify this for now and if it flakes
// more, we may need to revisit this test.
Expand Down
Loading