Skip to content

feat(auto-update-manager): show a system prompt about mismatched arch on apple arm on application start COMPASS-9592 #7133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 29, 2025
Merged

feat(auto-update-manager): show a system prompt about mismatched arch on apple arm on application start COMPASS-9592 #7133

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e1e219a
feat(auto-update-manager): show a system prompt about mismatched arch…
gribnoysup Jul 22, 2025
4cdfbb2
chore(auto-update-manager): error handling and wait for app ready
gribnoysup Jul 22, 2025
322b128
chore(compass): replace direct download with open external
gribnoysup Jul 25, 2025
a038c23
chore(auto-update-manager): share download logic, normalize url building
gribnoysup Jul 28, 2025
4ee47fb
chore(auto-update-manager): auto open on download
gribnoysup Jul 28, 2025
9a1e640
fix(auto-update-mananger): convert path to file url
gribnoysup Jul 29, 2025
3f53d4e
chore(compass): adjust unit test for new download behavior
gribnoysup Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions packages/compass/src/main/auto-update-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -827,11 +827,41 @@ class CompassAutoUpdateManager {
this.setState(AutoUpdateManagerState.RestartDismissed);
}

private static checkForMismatchedMacOSArch() {
const mismatchedOnArm =
isMismatchedArchDarwin() && getSystemArch() === 'arm64';

if (!mismatchedOnArm) {
return;
}

void dialog
.showMessageBox({
Comment on lines +871 to +872
Copy link
Collaborator Author

@gribnoysup gribnoysup Jul 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the performance issue is bad enough that it deserves a system prompt and not a toast or something similar, but I'm open to the feedback here

icon: COMPASS_ICON,
message: 'Mismatched architecture detected',
detail:
'You are currently using a build of Compass that is not optimized for Apple Silicon processors. This version might have significat performance issues when used. ' +
'Would you like to download the version of Compass optimized for Apple Silicon processors now?',
buttons: [
'Download Compass for Apple Silicon (Recommended)',
'Not now',
],
cancelId: 1,
})
.then(({ response }) => {
if (response === 0) {
const url = `https://compass.mongodb.com/api/v2/download/latest/compass/${this.autoUpdateOptions.channel}/darwin-arm64`;
void dl.download(BrowserWindow.getAllWindows()[0], url);
}
});
}

private static _init(
compassApp: typeof CompassApplication,
options: Partial<AutoUpdateManagerOptions> = {}
): void {
this.fetch = (url: string) => compassApp.httpClient.fetch(url);

compassApp.addExitHandler(() => {
this.stop();
return Promise.resolve();
Expand Down Expand Up @@ -867,6 +897,8 @@ class CompassAutoUpdateManager {
...options,
};

this.checkForMismatchedMacOSArch();

// TODO(COMPASS-7232): If auto-updates are not supported, then there is
// still a menu item to check for updates and then if it finds an update but
// auto-updates aren't supported it will still display a popup with an
Expand Down
Loading