chore(user-data): remove redundant withStats methods #7134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gribnoysup
commented
Jul 23, 2025
| }); | ||
| } | ||
|
|
||
| private mergeStats(pipeline: SavedPipeline, stats: Stats): SavedPipeline { |
Collaborator
Author
There was a problem hiding this comment.
That was the only case where we use it, and even then we always write our own number on create / update
gribnoysup
commented
Jul 23, 2025
| .number() | ||
| .transform((x) => new Date(x)) | ||
| .optional(), | ||
| .default(0) |
Collaborator
Author
There was a problem hiding this comment.
In the rarest case ever if someone still somehow doesn't have this value stored, we fallback to zero, the logic for writing this value to UserData was here for such a long time, I don't think this will ever be used
gribnoysup
commented
Jul 23, 2025
|
|
||
| export interface ReadAllResult<T extends z.Schema> { | ||
| data: z.output<T>[]; | ||
| errors: Error[]; |
Collaborator
Author
There was a problem hiding this comment.
This shape with returned errors is also not used anywhere really, we always pick up data, but it's a bigger change and this part of the interface doesn't depend on fs, so not touching it
gribnoysup
added
the
no-title-validation
lerouxb
approved these changes
Jul 23, 2025
nvs119
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are not meaningfully used in Compass and make it harder to have the same interface shared between web and desktop