Skip to content

Conversation

@mabaasit
Copy link
Collaborator

Description

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added
  • If this change updates the UI, screenshots/videos are added and a design review is requested
  • I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

Copilot AI review requested due to automatic review settings July 28, 2025 10:32
@mabaasit mabaasit requested a review from a team as a code owner July 28, 2025 10:32
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR changes the file extension for data modeling diagram exports from .compass to .mdm across the application, maintaining consistency between export, import, and testing functionality.

  • Updates file extension used for data modeling diagram exports and imports
  • Synchronizes test expectations with the new file extension
  • Ensures consistency across the data modeling feature

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
packages/compass-e2e-tests/tests/data-modeling-tab.test.ts Updates test to expect .mdm extension instead of .compass
packages/compass-data-modeling/src/services/open-and-download-diagram.ts Changes download service to use .mdm extension
packages/compass-data-modeling/src/components/import-diagram-button.tsx Updates file input to accept .mdm files

@mabaasit mabaasit changed the title chore(data-modeling): change file extension chore(data-modeling): change file extension COMPASS-9623 Jul 28, 2025
@paula-stacho
Copy link
Collaborator

Do we have the decision documented somewhere?

@mabaasit
Copy link
Collaborator Author

mabaasit commented Jul 28, 2025

Do we have the decision documented somewhere?

This change was proposed by Anna during the doc review. I updated the doc to reflect it as well.

@mabaasit mabaasit merged commit 84e8016 into main Jul 29, 2025
102 of 108 checks passed
@mabaasit mabaasit deleted the change-dm-file-ext branch July 29, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants