Skip to content

Conversation

Copilot AI review requested due to automatic review settings July 31, 2025 15:11
@lerouxb lerouxb requested a review from a team as a code owner July 31, 2025 15:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses test flakiness by replacing a direct assertion with a retry mechanism using waitUntil() to wait for toast text to eventually match the expected content.

  • Replaces immediate text assertion with waitUntil() retry pattern for toast message verification
  • Changes from throwing assertion to returning boolean for async waiting
Comments suppressed due to low confidence (1)

packages/compass-e2e-tests/tests/collection-bulk-delete.test.ts:112

  • The waitUntil() pattern should include a timeout and meaningful error message for when the condition is not met within the expected timeframe. Consider adding a timeout parameter and descriptive error message.
      return toastText.includes('1 document has been deleted.');

@addaleax addaleax changed the title chore: wait for the text to eventually match chore(e2e-tests): wait for the text to eventually match in bulk delete test Aug 1, 2025
@addaleax addaleax added the no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) label Aug 1, 2025
@addaleax addaleax merged commit 5f52ada into main Aug 1, 2025
61 of 63 checks passed
@addaleax addaleax deleted the bulk-delete-flake branch August 1, 2025 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants