fix: add relationship fields items and anyOf support COMPASS-9649 #7161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for extracting fields from nested array and mixed type schemas in the data modeling store. The change enables selection of fields that are nested under items (array schemas) and anyOf (mixed type schemas).
- Extends the
extractFieldsfunction to handleanyOfanditemsschema properties - Recursively processes array items and union type schemas to discover nested fields
- Adds comprehensive test coverage for the new functionality
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/compass-data-modeling/src/store/diagram.ts | Adds recursive field extraction for anyOf and items schema properties |
| packages/compass-data-modeling/src/store/diagram.spec.ts | Adds test cases covering flat, nested, array, and mixed type schema field extraction |
paula-stacho
added
the
feature flagged
addaleax
approved these changes
Aug 4, 2025
gribnoysup
reviewed
Aug 4, 2025
Comment on lines
+369
to
+374
| items: { | ||
| bsonType: 'object', | ||
| properties: { | ||
| prop3A: { bsonType: 'string' }, | ||
| }, | ||
| }, |
Collaborator
There was a problem hiding this comment.
Do you want to add a case where items is an array? Seems possible based on the implementation
Collaborator
Author
There was a problem hiding this comment.
True, let me add it!
gribnoysup
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is enabling selection of fields that are nested under an array or a mixed type
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes