Skip to content

Conversation

@paula-stacho
Copy link
Collaborator

@paula-stacho paula-stacho commented Aug 8, 2025

Description

Bumping the diagramming library to bring fixes for the edges rendering. Additionally, I found an inconsistency in the way the nodes were rendered, caused by our global css setting.

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added
  • If this change updates the UI, screenshots/videos are added and a design review is requested
  • I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

Copilot AI review requested due to automatic review settings August 8, 2025 15:13
@paula-stacho paula-stacho requested a review from a team as a code owner August 8, 2025 15:13
@github-actions github-actions bot added the fix label Aug 8, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes rendering issues with edges in the data modeling diagram by updating the diagramming library and addressing CSS box-sizing conflicts.

  • Updated @mongodb-js/diagramming from version 1.2.0 to 1.3.2 to bring edge rendering fixes
  • Added CSS override to force box-sizing: content-box for all elements within the diagram editor to resolve node rendering inconsistencies

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
packages/compass-data-modeling/package.json Updates diagramming library dependency to version 1.3.2
packages/compass-data-modeling/src/components/diagram-editor.tsx Adds CSS override for box-sizing to fix node rendering issues

userSelect: 'none',
},

['*']: {
Copy link

Copilot AI Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a universal selector (*) to override box-sizing for all elements is too broad and could have unintended side effects on nested components. Consider using a more specific selector targeting only the diagram elements that need this override, such as '.diagram-node' or '.diagram-element'.

Suggested change
['*']: {
['.diagram-node']: {

Copilot uses AI. Check for mistakes.
@paula-stacho paula-stacho added the feature flagged PRs labeled with this label will not be included in the release notes of the next release label Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature flagged PRs labeled with this label will not be included in the release notes of the next release fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants