fix(compass-indexes): fetch search indexes on refresh #7196
Conversation
Instead of fetching regular indexes twice, fetch regular and search indexes once each, as was most likely the intention here.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the compass-indexes plugin where the refresh functionality was incorrectly fetching regular indexes twice instead of fetching both regular and search indexes once each.
- Corrects duplicate
fetchRegularIndexes()call tofetchSearchIndexes()in the refresh handler - Ensures search indexes are properly refreshed when search indexes are supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| void store.dispatch(fetchRegularIndexes()); | ||
| if (options.isSearchIndexesSupported) { | ||
| void store.dispatch(fetchRegularIndexes()); | ||
| void store.dispatch(fetchSearchIndexes()); |
There was a problem hiding this comment.
The fix correctly addresses the bug where regular indexes were being fetched twice instead of fetching search indexes. This ensures both regular and search indexes are properly refreshed when supported.
lerouxb
left a comment
lerouxb
left a comment
There was a problem hiding this comment.
Oops. That must have been my fault.
gribnoysup
added
no release notes
|
Sorry, I think enabling required checks did something weird to some of the PRs, pushed an empty commit to retrigger the CI |
Instead of fetching regular indexes twice, fetch regular and search indexes once each, as was most likely the intention here.
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes