Skip to content

Conversation

@Anemy
Copy link
Member

@Anemy Anemy commented Aug 19, 2025

Had this in another branch as a drive by, figured I'd open a pr with it. There is still some prop-types usage in some of our older javascript (not yet typescript) components. In some of these typescript ones they were essentially duplicating and prone to not being correct anymore.

Copilot AI review requested due to automatic review settings August 19, 2025 14:40
@Anemy Anemy added the no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) label Aug 19, 2025
@Anemy Anemy requested a review from a team as a code owner August 19, 2025 14:40
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes React prop-types from TypeScript components since TypeScript already provides compile-time type checking that makes prop-types redundant. The removal includes both the import statements and the static propTypes declarations.

  • Removes prop-types imports and static propTypes declarations from TypeScript components
  • Removes prop-types dependency from package.json files
  • Maintains TypeScript interface definitions for type safety

Reviewed Changes

Copilot reviewed 18 out of 19 changed files in this pull request and generated no comments.

File Description
packages/compass-crud/src/components/table-view/* Removes prop-types from various table view components (cell renderer, editor, breadcrumb, etc.)
packages/compass-crud/src/components/* Removes prop-types from document-related components
packages/compass-aggregations/src/components/* Removes prop-types from aggregation pipeline components
packages/*/package.json Removes prop-types dependency from package.json files

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Anemy Anemy merged commit 3883a58 into main Aug 19, 2025
58 of 60 checks passed
@Anemy Anemy deleted the remove-react-prop-types branch August 19, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants