Skip to content

Conversation

@Anemy
Copy link
Member

@Anemy Anemy commented Aug 19, 2025

COMPASS-9902

Context: https://mongodb.slack.com/archives/C08KETBQ2QN/p1755603250954539?thread_ts=1755603016.988329&cid=C08KETBQ2QN

A bit tangential, but as it has so much dependencies on LG, we should probably move it under compass-components and re-export from there to make sure leafygreen deps are not spreading around the repo through transitive deps

Copilot AI review requested due to automatic review settings August 19, 2025 15:10
@Anemy Anemy requested a review from a team as a code owner August 19, 2025 15:10
@Anemy Anemy added the no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) label Aug 19, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR moves the diagramming dependency from direct usage to being re-exported through compass-components to prevent transitive leafygreen dependencies from spreading throughout the codebase.

  • Adds diagramming as a dependency to compass-components package
  • Creates a re-export module for diagramming components and types
  • Updates all imports across compass-data-modeling to use compass-components instead of direct diagramming imports

Reviewed Changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/compass-components/package.json Adds @mongodb-js/diagramming dependency
packages/compass-components/src/components/diagramming.tsx Creates re-export module for diagramming components and types
packages/compass-components/src/index.ts Exports the new diagramming re-export module
packages/compass-data-modeling/src/utils/nodes-and-edges.tsx Updates diagramming type imports to use compass-components
packages/compass-data-modeling/src/store/export-diagram.ts Updates DiagramInstance type import to use compass-components
packages/compass-data-modeling/src/store/analysis-process.ts Updates applyLayout import to use compass-components
packages/compass-data-modeling/src/services/export-diagram.tsx Updates all diagramming imports to use compass-components
packages/compass-data-modeling/src/components/export-diagram-modal.tsx Updates diagramming imports and reorganizes imports
packages/compass-data-modeling/src/components/diagram-editor.tsx Updates diagramming imports to use compass-components
packages/compass-data-modeling/src/components/diagram-editor.spec.tsx Updates test stubs to use compass-components instead of diagramming
packages/compass-data-modeling/src/components/data-modeling.tsx Updates DiagramProvider import to use compass-components

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Anemy Anemy changed the title chore: move diagramming dependency to compass-components chore: move diagramming dependency to compass-components COMPASS-9902 Sep 29, 2025
@gribnoysup gribnoysup closed this Oct 13, 2025
@gribnoysup
Copy link
Collaborator

Done in #7449

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants