Skip to content

chore(e2e-tests): wait for data modeling components in tests #7215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 22, 2025
Merged

chore(e2e-tests): wait for data modeling components in tests #7215

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d47fb6b
chore(e2e-tests): wait for data modeling components in tests
Anemy Aug 19, 2025
41f9a7e
fixup: remove duplicate wait for displayed
Anemy Aug 19, 2025
a09c3fb
Merge branch 'main' into wait-for-in-data-modeling-e2e-for-flakes
Anemy Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/compass-e2e-tests/tests/data-modeling-tab.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,11 +585,14 @@ describe('Data Modeling tab', function () {
const relationshipItem = drawer.$(
Selectors.DataModelCollectionRelationshipItem(relationshipId)
);
expect(await relationshipItem.isDisplayed()).to.be.true;
await relationshipItem.waitForDisplayed();
Copy link
Contributor

@lerouxb lerouxb Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

expect(await relationshipItem.getText()).to.include('testCollection-one');

// Edit the relationship
await relationshipItem.waitForDisplayed();
await relationshipItem
.$(Selectors.DataModelCollectionRelationshipItemEdit)
.waitForDisplayed();
await relationshipItem
.$(Selectors.DataModelCollectionRelationshipItemEdit)
.click();
Expand Down Expand Up @@ -619,7 +622,7 @@ describe('Data Modeling tab', function () {
.click();

// Verify that the relationship is removed from the list and the diagram
expect(await relationshipItem.isExisting()).to.be.false;
await relationshipItem.waitForDisplayed({ reverse: true });
await getDiagramEdges(browser, 0);
});

Expand Down