Skip to content

chore(components): use npm overrides to force transitive leafygreen dependencies to the same version of shared packages #7223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 25, 2025
Merged

chore(components): use npm overrides to force transitive leafygreen dependencies to the same version of shared packages #7223

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
95a8bd5
chore(components): use npm overrides to force transitive leafygreen d…
gribnoysup Aug 22, 2025
42a0d8c
chore(components): add lg-chat dependency and re-export
gribnoysup Aug 22, 2025
353e6ae
chore: use lg-chat components with overrides
gagik Aug 22, 2025
24a0e4a
chore(assistant): use imports from compass-components; update eslint …
gribnoysup Aug 22, 2025
58b2b3f
chore(components): revert changes to webpack config; patch button to …
gribnoysup Aug 25, 2025
c7150e5
chore(components): use commonjs in the patched export file
gribnoysup Aug 25, 2025
0251b8e
chore(assistant): disable failing tests
gribnoysup Aug 25, 2025
d3f187c
chore(collection): remove ErrorBoundary from tab header
gribnoysup Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions configs/eslint-plugin-compass/rules/no-leafygreen-outside-compass-components.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,12 +138,12 @@ module.exports = {

return {
ImportDeclaration(node) {
if (isImportSourceEquals(/^@leafygreen-ui/, node)) {
if (isImportSourceEquals(/^@(leafygreen-ui|lg-chat)/, node)) {
reportLeafygreenUsage(context, node, node.source);
}
},
CallExpression(node) {
if (isRequireSourceEquals(/^@leafygreen-ui/, node)) {
if (isRequireSourceEquals(/^@(leafygreen-ui|lg-chat)/, node)) {
reportLeafygreenUsage(context, node, node.arguments[0]);
}
},
Expand Down
1 change: 1 addition & 0 deletions configs/webpack-config-compass/polyfills/@leafygreen-ui/button/constants/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export const PRIMARY_BUTTON_INTERACTIVE_GREEN = '#00593F';
19 changes: 15 additions & 4 deletions configs/webpack-config-compass/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,17 @@ const sharedResolveOptions = (
'index.js'
),

// TODO: document what's going on here
'@leafygreen-ui/button/constants': path.resolve(
__dirname,
'..',
'polyfills',
'@leafygreen-ui',
'button',
'constants',
'index.js'
),

// This is an optional dependency of the AWS SDK that doesn't look like
// an optional dependency to webpack because it's not wrapped in try/catch.
'@aws-sdk/client-sso-oidc': false,
Expand Down Expand Up @@ -276,10 +287,10 @@ export function createElectronRendererConfig(
writeToDisk: true,
},
client: {
overlay:
process.env.DISABLE_DEVSERVER_OVERLAY === 'true'
? false
: { warnings: false, errors: true, runtimeErrors: true },
overlay: {
errors: true,
warnings: false,
},
},
https: false,
hot: opts.hot,
Expand Down
Loading