Skip to content

Conversation

@paula-stacho
Copy link
Collaborator

Description

The relationship management tests seems to be flaky in CI. I can't reproduce it locally, and I don't see anything wrong in the screenshot so I'm just adding a couple of waits around where it gets stuck. If nothing else, it might help us locate the problem.

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added
  • If this change updates the UI, screenshots/videos are added and a design review is requested
  • I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

Copilot AI review requested due to automatic review settings August 29, 2025 15:02
@paula-stacho paula-stacho requested a review from a team as a code owner August 29, 2025 15:02
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses flaky test behavior in the relationship management tests by adding wait conditions to ensure UI elements are properly loaded before interaction. The changes focus on making the test more robust in CI environments where timing issues may occur.

  • Adds waitForClickable() to ensure the edit button is interactive before clicking
  • Extracts the foreign cardinality select element to a variable and adds waitForDisplayed() before using it

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@paula-stacho paula-stacho added no release notes Fix or feature not for release notes no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) feature flagged PRs labeled with this label will not be included in the release notes of the next release labels Aug 29, 2025
@paula-stacho paula-stacho changed the title chore: add waiting for a flaky test chore: add wait for a flaky test Aug 29, 2025
@paula-stacho paula-stacho changed the title chore: add wait for a flaky test chore: add wait for flaky relationship management test Aug 29, 2025
@paula-stacho paula-stacho merged commit 23b2941 into main Sep 1, 2025
90 of 93 checks passed
@paula-stacho paula-stacho deleted the waitfor-flaky-bit branch September 1, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature flagged PRs labeled with this label will not be included in the release notes of the next release no release notes Fix or feature not for release notes no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants