-
Notifications
You must be signed in to change notification settings - Fork 238
chore(my-queries): make feature flag ready for saving user data COMPASS-9657 #7264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 7 commits
6b01986
893e6f7
505d90d
d13312d
6ea3db4
208a602
f484042
56e1223
c56a395
97ffb20
923e0d5
95fe0d7
eed1621
8f742a0
d117d7c
72d7115
6e9dfc8
0c8fea4
775d7e6
7d765a2
b8efa1c
de5fbff
2d86489
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,10 @@ | ||
import React, { useCallback, useLayoutEffect, useRef } from 'react'; | ||
import ReactDOM from 'react-dom'; | ||
import { | ||
resetGlobalCSS, | ||
css, | ||
Body, | ||
css, | ||
openToast, | ||
resetGlobalCSS, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Alphabetical 🙌 big fan. |
||
} from '@mongodb-js/compass-components'; | ||
import type { AllPreferences } from 'compass-preferences-model'; | ||
import { CompassWeb } from '../src/index'; | ||
|
@@ -137,6 +137,7 @@ const App = () => { | |
isAtlas && !!enableGenAIFeaturesAtlasOrg, | ||
optInGenAIFeatures: isAtlas && !!optInGenAIFeatures, | ||
enableDataModeling: true, | ||
enableMyQueries: true, | ||
}} | ||
onTrack={sandboxTelemetry.track} | ||
onDebug={sandboxLogger.debug} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,6 +15,13 @@ export { | |
} from './compass-query-storage'; | ||
export type { RecentQuery, FavoriteQuery } from './query-storage-schema'; | ||
|
||
// Export providers for use in applications | ||
export { | ||
FavoriteQueryStorageProvider, | ||
RecentQueryStorageProvider, | ||
PipelineStorageProvider, | ||
} from './provider'; | ||
|
||
|
||
// These are exported to aid in testing | ||
export const compassFavoriteQueryStorageAccess: FavoriteQueryStorageAccess = { | ||
getStorage() { | ||
|
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so this part is a bit confusing, but this configuration and feature flags relate to compass, not DE. so adding it here with stage: 'development' adds it to these "feature preview" flags that we have in Compass. They are also turned off by default, which we don't want here.
So instead of adding it to
FeatureFlags
, let's add it to the "other" section inUserConfigurablePreferences
andstoredUserPreferencesProps
. Example you can follow isenableImportExport
(make sure to use default true, you can still override that for compass-web, but the default compass setting for this feature is on).