Skip to content

Conversation

@addaleax
Copy link
Collaborator

@addaleax addaleax commented Sep 2, 2025

This reverts commit 04daaa9.

Copilot AI review requested due to automatic review settings September 2, 2025 17:31
@addaleax addaleax requested a review from a team as a code owner September 2, 2025 17:31
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This is a revert commit that undoes the field type update functionality introduced in commit 04daaa9. The changes remove field type modification capabilities from the data modeling feature.

  • Removes getSchemaWithNewTypes function and related field type change functionality
  • Reverts test fixture data model from _id back to id field
  • Disables field type editing UI and removes related actions

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/compass-data-modeling/test/fixtures/data-model-with-relationships.json Reverts field name from _id back to id in test fixture
packages/compass-data-modeling/src/utils/schema-traversal.tsx Removes field type change utilities and inlines type extraction logic
packages/compass-data-modeling/src/utils/schema-traversal.spec.tsx Removes tests for field type change functionality
packages/compass-data-modeling/src/store/diagram.ts Removes changeFieldType action creator
packages/compass-data-modeling/src/store/apply-edit.ts Removes ChangeFieldType case from edit application logic
packages/compass-data-modeling/src/components/drawer/field-drawer-content.tsx Disables field type editing UI and removes related state management
packages/compass-data-modeling/src/components/drawer/diagram-editor-side-panel.spec.tsx Updates test expectations to reflect reverted field names and removes field type change tests

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Anemy
Copy link
Member

Anemy commented Sep 2, 2025

Just merged in #7266 can we close this then?

@addaleax
Copy link
Collaborator Author

addaleax commented Sep 2, 2025

Seems like it! I didn't realize #7266 would address this since it was opened before #7248 was merged

@addaleax addaleax closed this Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants