-
Notifications
You must be signed in to change notification settings - Fork 239
feat(compass-collection) Fill in the script screen of the Generate Mock Data modal flow #7286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
leo-generali
wants to merge
11
commits into
mongodb-js:main
from
leo-generali:CLOUDP-333859-script-output-screen
Closed
feat(compass-collection) Fill in the script screen of the Generate Mock Data modal flow #7286
leo-generali
wants to merge
11
commits into
mongodb-js:main
from
leo-generali:CLOUDP-333859-script-output-screen
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c8dd1ff to
6c55005
Compare
7713d6d to
13a8e9a
Compare
|
@leo-generali Can you provide a screenshot? Not a blocker btw |
kpamaran
reviewed
Sep 5, 2025
packages/compass-collection/src/components/mock-data-generator-modal/script-screen.tsx
Outdated
Show resolved
Hide resolved
kpamaran
reviewed
Sep 5, 2025
packages/compass-collection/src/components/mock-data-generator-modal/script-screen.tsx
Outdated
Show resolved
Hide resolved
|
I think it's ready for review @leo-generali. I only had nits |
4 tasks
|
Closed. Refer to #7296 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types of changes