chore(components): replace vendored drawer with lg dependency #7289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gribnoysup
changed the title
gribnoysup
added
the
no-title-validation
lerouxb
reviewed
Sep 5, 2025
| }, | ||
|
|
||
| // drawer content > title content | ||
| '& > div:nth-child(2) > div:nth-child(2) > div:first-child > div:first-child > div:first-child > div:first-child': |
There was a problem hiding this comment.
Yeah, I'll report this one to leafygreen, and we don't have enough control there to target this otherwise unfortunately (has is still very nice for this, but breaks jsdom)
lerouxb
approved these changes
Sep 5, 2025
gagik
approved these changes
Sep 5, 2025
|
Hmmm, probably broke some selectors |
|
Nope, not selectors, actually broken behavior shows up in e2e, will investigate |
gribnoysup
force-pushed
the
replace-vendored-drawer-component-with-lg-dependency
branch
from
b9f1dfa to
92af9ee
Compare
gribnoysup
force-pushed
the
replace-vendored-drawer-component-with-lg-dependency
branch
from
92af9ee to
793b817
Compare
|
Okay, finally figured it out, this should now pass all e2e |
gribnoysup
deleted the
replace-vendored-drawer-component-with-lg-dependency
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the fixes required for us to switch landed on the leafygreen side, so we can drop the vendored code. There are no visual differences, but just in case screenshots from this branch: