Skip to content

Conversation

@lerouxb
Copy link
Contributor

@lerouxb lerouxb commented Sep 8, 2025

We might still change this further and just have two separate instructions prompts so we have more flexibility in editing them, but at least this puts what we have so far together.

@Copilot Copilot AI review requested due to automatic review settings September 8, 2025 13:53
@lerouxb lerouxb requested a review from a team as a code owner September 8, 2025 13:53
@lerouxb lerouxb added the no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) label Sep 8, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the compass assistant configuration by moving hardcoded app name strings to a centralized constant object. The change improves maintainability by consolidating the app name values used in assistant prompts into a single location.

  • Introduces APP_NAMES_FOR_PROMPT constant object to centralize app name configurations
  • Updates both Compass and Compass Web applications to use the centralized constants
  • Exports the new constant from the compass-assistant package for wider usage

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
packages/compass-assistant/src/prompts.ts Adds APP_NAMES_FOR_PROMPT constant object with standardized app names
packages/compass-assistant/src/index.tsx Exports the new APP_NAMES_FOR_PROMPT constant
packages/compass/src/app/components/home.tsx Updates to use APP_NAMES_FOR_PROMPT.Compass instead of hardcoded string
packages/compass-web/src/entrypoint.tsx Updates to use APP_NAMES_FOR_PROMPT['Data Explorer'] instead of hardcoded string

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@lerouxb lerouxb force-pushed the move-appNameForPrompt branch from 3e1077c to 0b692c8 Compare September 9, 2025 07:24
@lerouxb lerouxb merged commit a0ad514 into main Sep 9, 2025
52 of 56 checks passed
@lerouxb lerouxb deleted the move-appNameForPrompt branch September 9, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants