Skip to content

Conversation

kpamaran
Copy link
Collaborator

@kpamaran kpamaran commented Sep 16, 2025

Description

Note: This feature is in development. Normally, if the feature was already rolled out we would version the API change.

Previously there was a zod parse failure because the response data is not wrapped in content. This also removes two fields isArray and probability from the contract, to get ahead of a planned removal of the 2 fields from the backend.

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added
  • If this change updates the UI, screenshots/videos are added and a design review is requested
  • I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@kpamaran kpamaran requested review from jcobis and ncarbon September 16, 2025 19:17
@kpamaran kpamaran requested a review from a team as a code owner September 16, 2025 19:17
@kpamaran kpamaran added the fix label Sep 16, 2025
@kpamaran kpamaran requested a review from mabaasit September 16, 2025 19:17
@codeowners-service-app
Copy link

Assigned kraenhansen for team compass-developers because mabaasit is out of office.

@kpamaran kpamaran added the no release notes Fix or feature not for release notes label Sep 16, 2025
@kpamaran
Copy link
Collaborator Author

kpamaran commented Sep 16, 2025

@jcobis please double-check the removal of isArray and probability cover all the low hanging fruit API changes

Copy link
Collaborator

@jcobis jcobis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jcobis jcobis merged commit 0e2a2e9 into main Sep 19, 2025
57 of 59 checks passed
@jcobis jcobis deleted the fix-api-contract-and-anticipate-change branch September 19, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix no release notes Fix or feature not for release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants