WIP drawer section guidecue hack #7343
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lerouxb
commented
Sep 18, 2025
| }: { | ||
| buttonProps: IconButtonPropsWithoutChildren; | ||
| }) => ( | ||
| <GuideCue<HTMLButtonElement> |
There was a problem hiding this comment.
In case it isn't obvious this is our GuideCue from compass-components which wrap's leafygreen's guidecue and exports a different interface, not the raw leafygreen guidecue.
lerouxb
commented
Sep 18, 2025
| | 'onClick' | ||
| >; | ||
|
|
||
| export type IconButtonPropsWithoutChildren = Omit< |
There was a problem hiding this comment.
I don't even know. Look away... 😆
|
closing in favour of #7347 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Terrible hack to try and wrap a guidecue around the drawer toolbar button. Which in itself contains a tooltip.
Right now on initial render it focuses the guidecue and that in turn shows the toolbar button's tooltip for some reason:
I wouldn't go with this, but figured it might be useful as a sketch for what we're trying to achieve.