chore(compass-assistant): keep track of confirmation and entry point sources #7344
Conversation
gagik
requested review from
Copilot and
nbbeeken
and removed request for
Copilot
gagik
added
the
no-title-validation
| */ | ||
| isPermanent?: boolean; | ||
| /** The source of the message (i.e. the entry point used) */ | ||
| source?: 'explain plan' | 'performance insights' | 'connection error'; |
There was a problem hiding this comment.
I'm wondering if we should treat normal typed prompts as an "entry point" and then this becomes required and we can easily segment all messages. Like I'm worried about the "ergonomics" of filtering by no source and the ambiguity introduced by a field that's not there. Maybe a question for the analytics team?
There was a problem hiding this comment.
Similar question for spaces in the value. Wondering if that's going to be annoying to filter on in their interface. But that's a super minor nit.
There was a problem hiding this comment.
Pull Request Overview
This PR adds telemetry tracking for assistant entry point sources and confirmation interactions. The changes enhance the tracking of user interactions with the AI assistant by recording where users enter the assistant (entry point sources) and their responses to confirmation prompts.
- Adds new telemetry event types for tracking assistant entry points and confirmation submissions
- Updates feedback tracking to include source information indicating how the user accessed the assistant
- Adds comprehensive test coverage for the new telemetry tracking functionality
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/compass-telemetry/src/telemetry-events.ts | Defines new telemetry events for entry point usage and confirmation submissions, updates feedback event to include source |
| packages/compass-assistant/src/components/assistant-chat.tsx | Implements telemetry tracking for feedback and confirmation interactions with source information |
| packages/compass-assistant/src/components/assistant-chat.spec.tsx | Adds test cases for telemetry tracking with source information and fallback scenarios |
| packages/compass-assistant/src/compass-assistant-provider.tsx | Updates message metadata to include entry point source information |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
2 participants
Some improvements to the sources of entry points sent with feedback and when confirming.