Skip to content

chore(ci): remove the "expires" field from aggrid ignores COMPASS-9862 #7346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2025
Merged

chore(ci): remove the "expires" field from aggrid ignores COMPASS-9862 #7346

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .snyk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,12 @@ ignore:
reason: >-
Not applicable as we do not use a valueFormatter or cellRenderer
function
expires: 2025-09-17T13:05:57.065Z
created: 2024-01-18T18:27:24.353Z
SNYK-JS-AGGRIDCOMMUNITY-7414157:
- '*':
reason: >-
Not applicable as we don't use ag-grid utils and the library never
passes user input directly to the merge function
Comment on lines 9 to 15
Copy link

Copilot AI Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the expires field makes this ignore permanent; without a scheduled re-evaluation, a future change in usage (e.g., introduction of valueFormatter/cellRenderer) could leave a real vulnerability suppressed. Consider retaining an expires field (even if far in the future) or adding an explicit periodic review process annotation to ensure continued validity.

Copilot uses AI. Check for mistakes.

Copy link

Copilot AI Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ignore entry is now indefinite; if future code begins using ag-grid utils or passes user-influenced data into merge, the suppressed issue would remain hidden. Recommend reinstating an expires timestamp or adding a documented review note to mitigate the risk of stale ignores.

Suggested change
passes user input directly to the merge function
passes user input directly to the merge function
expires: 2025-03-17T13:05:57.071Z

Copilot uses AI. Check for mistakes.

expires: 2025-09-17T13:05:57.065Z
created: 2024-09-17T13:05:57.071Z
SNYK-JS-ELECTRON-8642944:
- '*':
Expand Down
Loading