fix(e2e): use a larger test fixture for the abort import test COMPASS-9858 #7352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a timing issue in end-to-end tests where import operations complete too quickly for abort functionality to be properly tested. The solution replaces smaller test fixtures with larger ones to ensure imports take sufficient time to allow the abort operations to be tested reliably.
- Updates three test cases to use larger CSV and JSON fixtures (279,712 documents vs 16,116)
- Modifies the import confirm selector to only target enabled buttons
- Adds explanatory comments about the fixture size and testing rationale
Reviewed Changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/compass-e2e-tests/tests/collection-import.test.ts | Updates three abort import tests to use larger fixtures and adds explanatory comments |
| packages/compass-e2e-tests/helpers/selectors.ts | Refines import confirm selector to target only enabled buttons |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
lerouxb
commented
Sep 22, 2025
| '[data-testid="import-modal"] [data-testid="analyze-error"]'; | ||
| export const ImportConfirm = | ||
| '[data-testid="import-modal"] [data-testid="import-button"]'; | ||
| '[data-testid="import-modal"] [data-testid="import-button"][aria-disabled="false"]'; |
There was a problem hiding this comment.
Realising this was probably the reason behind so many flakes..
nbbeeken
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPASS-9858
In CI the import frequently succeeds before the tests abort the error. By using a larger fixture we can avoid that.