-
Notifications
You must be signed in to change notification settings - Fork 233
feat(compass-collection): Render Output Script in Result Screen - Mock Data Generator CLOUDP-333858 #7355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat(compass-collection): Render Output Script in Result Screen - Mock Data Generator CLOUDP-333858 #7355
Changes from 28 commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
a558ea4
feat(compass-collection): LLM Output Validation - Mock Data Generato…
ncarbon 9057d30
revert changes to faker method validation logic
ncarbon c4485c1
WIP
jcobis 193161f
Update schema editor screen
jcobis df1e8f8
add ts error annotation back and more context in docstring
ncarbon beecd6b
address: update FakerFieldMapping to use MongoDBFieldType and improve…
ncarbon d1989d9
remove @ts-expect-error annotation, annotate type import
ncarbon 452d8f8
refactor: update MongoDBFieldType import paths and improve type usage…
ncarbon 70f02bf
remove 'content' field from mock data schema response
ncarbon a1bdd4d
fix: update fakerArgs and probability handling in validateFakerSchema…
ncarbon dd22acf
clean up probability handling in AtlasAiService and in faker schema v…
ncarbon bd3f61a
rename FakerSchemaMapping to LlmFakerMapping
ncarbon 6a6307b
validate mongoType with zod and move fakerSchema transformation metho…
ncarbon 333b4bc
rename values
ncarbon 6a8bb00
WIP
jcobis 3ddc648
fix generative-ai tests
ncarbon b93c1bc
More tests
jcobis 35e1724
WIP
jcobis 6324e57
Types
jcobis 8a0332e
Merge branch 'CLOUDP-333855/faker-schema-validation' of github.com:mo…
jcobis 1f6131b
WIP
jcobis 6785b20
Merge branch 'main' of github.com:mongodb-js/compass into CLOUDP-333858
jcobis f4c8c19
Fix merge conflicts
jcobis 3b3f054
Merge branch 'main' into CLOUDP-333858
jcobis 05745e3
DB and collection name parsing
jcobis 4ec9417
WIP
jcobis 52af9b4
WIP
jcobis c6512f0
Comments
jcobis 2d1075c
Error banner
jcobis 35efd8d
Code component scrollable
jcobis 0142677
Convert to use prettier
jcobis 6e36bde
Connect redux directly
jcobis 6bacb48
Style
jcobis d2cd422
Error banner spacing
jcobis c2eb876
Escape chars in collection and db names
jcobis 2487387
Merge branch 'main' into CLOUDP-333858
jcobis b4a4dc3
Accidental push
jcobis 46169b4
Fix accidental push
jcobis 6c9f7ab
Dependency for prettier
jcobis a5690bd
Merge branch 'main' of github.com:mongodb-js/compass into CLOUDP-333858
jcobis 6599e0a
Merge branch 'main' of github.com:mongodb-js/compass into CLOUDP-333858
jcobis 3cfcb08
Merge conflict
jcobis 70f266e
Merge conflict
jcobis 3903751
Merge conflict
jcobis 66e74a7
Merge branch 'main' into CLOUDP-333858
gribnoysup cc88e92
Merge branch 'main' into CLOUDP-333858
jcobis f8cda08
Escape character
jcobis 18eeff0
Code comment
jcobis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a weird split in component responsibilities, feels better suited for the ScriptScreen. So is the property passing, all this stuff is coming from state, so you should just connect the ScriptScreen component to this state directly as the redux documentation recommends