feat: add diagram breadcrumbs COMPASS-9800 #7358
Conversation
paula-stacho
requested review from
Copilot and
ivandevp
and removed request for
Copilot
paula-stacho
added
the
feature flagged
There was a problem hiding this comment.
Pull Request Overview
This PR adds diagram breadcrumbs functionality to the data modeling editor toolbar, allowing users to navigate back to the diagrams list from within a diagram.
Key changes:
- Added breadcrumb navigation with "diagrams" and current diagram name
- Updated the Breadcrumbs component to support non-clickable last items
- Added corresponding test coverage for the new breadcrumb functionality
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| diagram-editor-toolbar.tsx | Added breadcrumb navigation with workspace integration and UI layout updates |
| diagram-editor-toolbar.spec.tsx | Added test coverage for breadcrumb functionality and workspace service mocking |
| breadcrumb.tsx | Enhanced Breadcrumbs component to support non-clickable final breadcrumb items |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
packages/compass-data-modeling/src/components/diagram-editor-toolbar.tsx
Show resolved
Hide resolved
| key={[items.length - 1, lastItem.name].join('')} | ||
| className={cx( | ||
| textStyles, | ||
| darkMode ? lastItemStylesDark : lastItemStylesLight |
There was a problem hiding this comment.
A styling question, I'm finding the darkmode a bit dark for the last item. Does it look dark to you? Maybe we could ask design about a lighter text color there.
Not a blocker, it's something that's already impacting the other breadcrumbs, and it's also a small change if we ever want to.
There was a problem hiding this comment.
Hmm, it does looks dark 🤔 According to devtools the contrast ratio is above 5, and given that we're generally trying to avoid high contrast, it should be okay.
2 participants
Description
Adding breadcrumbs, for now just the diagram list > diagram name.
Side change: Breadcrumbs was expecting each item to have an onClick, even though the last item is not clickable. Now it's optional.
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes