-
Notifications
You must be signed in to change notification settings - Fork 237
feat(compass, preferences): implement zoom level persistence COMPASS-9905 #7363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 9 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
5b41506
feat: add optional zoom level to InternalUserPreferences
miya 79e7d61
feat: implement debounced zoom level saving and restoration
miya 44e26f8
fix: simplify zoom level setting by removing validation checks
miya fa1e13d
fix: validate zoom level before restoration to ensure it falls within…
miya 431c5b0
Merge branch 'main' into feat/zoom-level-persistence
miya 4ee3f96
fix: remove console log for restoring zoom level
miya 612e246
Update packages/compass/src/app/application.tsx
miya 6b4ce4d
fix: prevent memory leaks in zoom timeout handling
miya 0683939
imprv: execute zoom process first
miya 9fb0100
Update packages/compass/src/app/application.tsx
miya bd6d862
fix: clarify comment for zoom level clamping
miya 19c2743
Revert "fix: clarify comment for zoom level clamping"
miya fae84c3
fix: clarify comment for zoom level clamping
miya 356f727
fix: simplify zoom level clamping code
miya adc6866
fix: zoomLevel saving process runs in the background
miya adec59a
Merge branch 'main' into feat/zoom-level-persistence
miya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The empty catch block with 'noop' comment provides no debugging information. Consider logging the error or adding a more descriptive comment explaining why errors are intentionally ignored.
Copilot uses AI. Check for mistakes.