Skip to content

Conversation

ivandevp
Copy link
Collaborator

@ivandevp ivandevp commented Sep 26, 2025

Description

Given the different size between refresh button and loading spinner, a flicker was visible when switching between states. This PR fixes that flickering.

Before:

353827559-3767a84d-01ed-4fc8-93d6-abb1d2f873db

After:

refresh-button-flickering-fixed.mov

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added
  • If this change updates the UI, screenshots/videos are added and a design review is requested
  • I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

There's still one flickering because when we jump into the loading state, we reset the counter until it's calculated again, causing the page size selector to reflow and the counter to hide/show. Any ideas on how to improve this?

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@ivandevp ivandevp marked this pull request as ready for review September 26, 2025 09:40
@ivandevp ivandevp requested a review from a team as a code owner September 26, 2025 09:40
@ivandevp ivandevp requested a review from mabaasit September 26, 2025 09:40
@ivandevp ivandevp changed the title lfix(crud-toolbar): flickering in refresh button fix(crud-toolbar): flickering in refresh button COMPASS-8138 Sep 26, 2025
@ivandevp ivandevp merged commit d08e7ba into main Sep 29, 2025
62 of 63 checks passed
@ivandevp ivandevp deleted the fix/crud-toolbar-loading branch September 29, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants