Skip to content

chore(compass-components): push toast behind modal COMPASS-8162 #7414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(compass-components): push toast behind modal COMPASS-8162 #7414

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/compass-components/src/hooks/use-toast.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,9 +195,9 @@ const ToastAreaMountedContext = React.createContext(false);

export const ToastArea: React.FunctionComponent = ({ children }) => {
const stackedContext = useStackedComponent();
// We always want to show the toast over modal or other stacked components that may hide the toast and hence +1
const stackedElemStyles = useMemo(() => {
const zIndex = stackedContext?.zIndex ? stackedContext.zIndex + 1 : 1;
// We always want to show the toast under the modal
const toastPortalStyles = useMemo(() => {
const zIndex = stackedContext?.zIndex ? stackedContext.zIndex - 1 : 0;
Copy link
Preview

Copilot AI Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting z-index to 0 when no stacked context exists may cause toasts to appear behind other page elements. Consider using a positive default value like 1 to ensure toasts remain visible above normal page content.

Suggested change
const zIndex = stackedContext?.zIndex ? stackedContext.zIndex - 1 : 0;
const zIndex = stackedContext?.zIndex ? stackedContext.zIndex - 1 : 1;

Copilot uses AI. Check for mistakes.

return css({ zIndex });
}, [stackedContext]);

Expand All @@ -207,7 +207,7 @@ export const ToastArea: React.FunctionComponent = ({ children }) => {

return (
<ToastAreaMountedContext.Provider value={true}>
<ToastProvider portalClassName={stackedElemStyles}>
<ToastProvider portalClassName={toastPortalStyles}>
<ToastStateHandler>{children}</ToastStateHandler>
</ToastProvider>
</ToastAreaMountedContext.Provider>
Expand Down