Skip to content

Conversation

lerouxb
Copy link
Contributor

@lerouxb lerouxb commented Oct 7, 2025

This reverts commit e8c45e5. (#7357)

Turns out freeStorage: 1 is a footgun:

If the instance has a large number of collections or indexes, obtaining free space usage data may cause processing delays. To gather dbStats information without free space details, either set freeStorage to 0 or do not include the field.

@lerouxb lerouxb requested a review from a team as a code owner October 7, 2025 07:12
@lerouxb lerouxb requested review from Copilot and ivandevp October 7, 2025 07:12
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts a previous commit that added uncompressed data stat fields to database collections, removing the freeStorage: 1 parameter from dbStats commands due to performance concerns. The MongoDB documentation warns that this option can cause processing delays when instances have many collections or indexes.

  • Removes freeStorage: 1 parameter from dbStats command calls
  • Eliminates free storage size fields and calculated storage size logic
  • Updates UI labels and test expectations to reflect the simplified storage display

Reviewed Changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/data-service/src/data-service.ts Removes freeStorage: 1 parameter from dbStats command
packages/data-service/src/run-command.ts Removes free storage size type definitions
packages/data-service/src/instance-detail-helper.ts Removes free storage size from database details
packages/database-model/lib/model.js Removes calculated storage size derived property
packages/databases-collections-list/src/databases.tsx Simplifies storage display to show raw storage size
packages/databases-collections-list/src/collections.tsx Updates collection storage labels and removes separate uncompressed data display
packages/databases-collections-list/src/index.spec.tsx Updates test expectations for simplified storage display
packages/compass-workspaces/src/index.spec.tsx Removes free storage size from test data
packages/compass-components/src/components/inline-definition.tsx Removes unused CSS class and import

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@gribnoysup gribnoysup added the no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) label Oct 7, 2025
@lerouxb lerouxb merged commit 1282f39 into main Oct 7, 2025
83 of 89 checks passed
@lerouxb lerouxb deleted the revert-freeStorage branch October 7, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants