feat: DM inline field name edit COMPASS-9798 #7454
Open
+392
−245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paula-stacho
added
the
feature flagged
paula-stacho
force-pushed
the
COMPASS-9798
branch
from
5252f4b to
66ba6cf
Compare
There was a problem hiding this comment.
Pull Request Overview
Implements inline field name editing in the data modeling diagram along with supporting selectors, store wiring, and tests.
- Adds editable flag to schema-derived fields and prevents _id from being renamed
- Wires renameField action through diagram editor components
- Adds new e2e test and selectors for selecting, adding, and renaming fields
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/compass-e2e-tests/tests/data-modeling-tab.test.ts | Adds e2e test for field selection, addition, and inline rename; refactors drawer close logic. |
| packages/compass-e2e-tests/helpers/selectors.ts | Introduces new selectors for field name input, add field button, field node, and inline edit input. |
| packages/compass-data-modeling/src/utils/nodes-and-edges.ts | Adds editable property to field objects based on isIdField logic. |
| packages/compass-data-modeling/src/utils/nodes-and-edges.spec.ts | Updates unit tests to assert editable flag, including non-editable _id. |
| packages/compass-data-modeling/src/components/diagram-editor.tsx | Wires renameField handler into diagram content and passes it to node creation logic. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
368
to
373
| onPaneClick, | ||
| onEdgeClick, | ||
| onFieldClick, | ||
| onRenameField, | ||
| onNodeDragStop, | ||
| onConnect, |
There was a problem hiding this comment.
onRenameField is included in this dependency array but (based on the diff) does not appear to be referenced inside the corresponding memoized callback. Remove it if unused to avoid unnecessary recalculations.
Copilot uses AI. Check for mistakes.
|
Assigned |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding inline edit for fields.
https://github.com/user-attachments/assets/f9f12d7d-28be-402d-849c-257b6fe210b7
Also adding e2e for selecting, adding and editing field.
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes