Skip to content

Conversation

@paula-stacho
Copy link
Collaborator

@paula-stacho paula-stacho commented Nov 13, 2025

Description

When looking at amplitude I've noticed we somehow skipped the FieldAdded event. We also forgot to properly assign the source for the 2 field edit events.

After:
Screenshot 2025-11-13 at 11 45 33

(Field type edit from diagram is in progress - cc @mabaasit)

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added
  • If this change updates the UI, screenshots/videos are added and a design review is requested
  • If this change could impact the load on the MongoDB cluster, please describe the expected and worst case impact
  • I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@paula-stacho paula-stacho requested a review from a team as a code owner November 13, 2025 10:46
@github-actions github-actions bot added the fix label Nov 13, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds telemetry tracking for the previously missing "Field Added" event and properly assigns the source parameter ('side_panel' or 'diagram') for field edit operations in the data modeling feature.

  • Added DataModelingDiagramFieldAdded event type and tracking
  • Updated field rename and type change events to include source parameter from both side panel and diagram interactions
  • Refactored function signatures to accept source tracking parameter

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
packages/compass-telemetry/src/telemetry-events.ts Added new DataModelingDiagramFieldAdded event type and updated existing field event types to include 'diagram' as a valid source
packages/compass-data-modeling/src/store/diagram.ts Added telemetry tracking calls for field additions and updated function signatures to accept and pass source parameter
packages/compass-data-modeling/src/components/drawer/field-drawer-content.tsx Updated function signatures and call sites to pass 'side_panel' as the source for field operations
packages/compass-data-modeling/src/components/diagram-editor.tsx Updated function signatures and call sites to pass 'diagram' as the source for field operations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@paula-stacho paula-stacho added no release notes Fix or feature not for release notes and removed fix labels Nov 13, 2025
@github-actions github-actions bot added the fix label Nov 13, 2025
@paula-stacho paula-stacho merged commit 0a4fc42 into main Nov 14, 2025
71 of 74 checks passed
@paula-stacho paula-stacho deleted the COMPASS-10066 branch November 14, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix no release notes Fix or feature not for release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants