feat(query-bar): add _id: ObjectId('') around pasted object id COMPASS-10077 #7569
+84
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to automatically wrap pasted MongoDB ObjectIds with the proper query syntax. When a user pastes a 24-character hexadecimal ObjectId enclosed in curly braces (e.g., {578cfb38d5021e616087f53f}), the code now transforms it into a valid query format: { _id: ObjectId("578cfb38d5021e616087f53f") }.
Key changes:
- Refactored the
lenientlyFixQueryfunction to separate concerns into distinct helper functions - Added ObjectId detection and wrapping functionality
- Improved code organization by extracting brace-escaping logic into its own function
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/compass-query-bar/src/query/leniently-fix-query.ts | Refactored query fixing logic into separate functions and added ObjectId detection/wrapping |
| packages/compass-query-bar/src/query/leniently-fix-query.spec.ts | Added comprehensive test cases for ObjectId pasting scenarios |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPASS-10077
We had similar functionality in Compass a long time ago. I was looking at NumberLong(number > Max js int) and had this as a drive by so I figured I'd add it in a separate pr. If folks feel this isn't needed please let me know! Happy to close without merging.
object.id.query.fix.mp4