chore(ci): when deploying compass web, deploy to all previous environments to make sure release version is consistent#7961
Draft
gribnoysup wants to merge 1 commit intomainfrom
Conversation
…ments to make sure release version is consistent
3ceaad8 to
e06cc1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch changes compass-web deploy workflow to accoutn for some things we discussed during the demo of the new release:
As mentioned, I went back and forth a bit about how to implement this, at the end I decided to keep some of the shell scripts right in the action jobs because moving them to dedicated scripts was making reading through the flow more confusing. I moved the latest release resolution to its own thing though because this one was the messiest in bash and needs to be reused in a couple of places. Tell me though if you think that those are too hard to read through
Code-wise I think it's ready for review, I tested all the parts separately and don't expect changes. Draft while I'm testing this with real GHA