Skip to content

fix(NODE-6772): remove prod dependency on bson #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 21, 2025
Merged

fix(NODE-6772): remove prod dependency on bson #31

merged 2 commits into from
Feb 21, 2025

Conversation

@W-A-James
Copy link
Contributor

@W-A-James W-A-James commented Feb 20, 2025 •
edited
Loading

Description

What is changing?

Is there new documentation needed for these changes?

What is the motivation for this change?

Double check the following

  • Ran npm run check:eslint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

W-A-James
W-A-James commented Feb 20, 2025
View reviewed changes
@W-A-James W-A-James marked this pull request as ready for review February 20, 2025 20:56
@W-A-James W-A-James requested a review from a team as a code owner February 20, 2025 20:56
@baileympearson baileympearson self-assigned this Feb 20, 2025
@baileympearson baileympearson added the Primary Review Pull request is being reviewed by primary reviewer label Feb 20, 2025
@baileympearson
Copy link
Collaborator

baileympearson commented Feb 21, 2025

Tests are running now: https://spruce.mongodb.com/version/67b7bcb0a5b5b0000775ee5e/tasks

One task did time out, but I believe this is unrelated (the changes here don't impact the performance of BSON's tests, just the runner).

@baileympearson baileympearson merged commit bfd4a57 into main Feb 21, 2025
6 checks passed
@baileympearson baileympearson deleted the NODE-6772/remove-bson-dep branch February 21, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baileympearson baileympearson baileympearson approved these changes

Assignees

@baileympearson baileympearson

Labels

Primary Review Pull request is being reviewed by primary reviewer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@W-A-James @baileympearson