Skip to content

Conversation

@W-A-James
Copy link
Contributor

@W-A-James W-A-James commented Mar 5, 2025

Description

What is changing?

Add tags to metadata subdocument instead of info subdocument when writing out results.

Is there new documentation needed for these changes?

What is the motivation for this change?

Double check the following

  • Ran npm run check:eslint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@W-A-James W-A-James marked this pull request as ready for review March 5, 2025 19:49
@W-A-James W-A-James requested a review from a team as a code owner March 5, 2025 19:49
@W-A-James W-A-James changed the title test(NODE-6806): move benchmark tags into correct place fix(NODE-6806): move benchmark tags into correct place Mar 5, 2025
@nbbeeken nbbeeken self-assigned this Mar 5, 2025
@nbbeeken nbbeeken added the Primary Review Pull request is being reviewed by primary reviewer label Mar 5, 2025
nbbeeken
nbbeeken previously approved these changes Mar 5, 2025
@nbbeeken nbbeeken merged commit fe3ea15 into main Mar 5, 2025
6 checks passed
@nbbeeken nbbeeken deleted the NODE-6806 branch March 5, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Primary Review Pull request is being reviewed by primary reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants