fix(devtools-proxy-support): lazily load expensive dependencies MONGOSH-1853 #446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notably, this is referring to `pac-proxy-agent` and `ssh2`, which both involve somewhat complex setups. Also, since `ssh2` includes a WebAssembly implementation of a cryptographic algorithm, we should make sure not to load it in FIPS mode.
addaleax
changed the title
kmruiz
reviewed
Aug 7, 2024
kmruiz
reviewed
Aug 7, 2024
kmruiz
approved these changes
Aug 7, 2024
alenakhineika
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notably, this is referring to
pac-proxy-agentandssh2, which both involve somewhat complex setups.Also, since
ssh2includes a WebAssembly implementation of a cryptographic algorithm, we should make sure not to load it in FIPS mode.(This does not fully remove the need for loading this package lazily, since it still relies on the
httppackage directly.)Description
Open Questions
Checklist