fix(devtools-proxy-support): work around more issues with proxy-agent #451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work around more issues identified while adding testing for proxy support to mongosh. Admittedly, at this point the original choice to use `proxy-agent` might not seem like the wisest anymore :) We’ll see how receptive their maintainers are to our patches – so far, none of the issues discovered should be fundamentally in conflict with the packages’ design philosophy.
mabaasit
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work around more issues identified while adding testing for proxy support to mongosh.
Admittedly, at this point the original choice to use
proxy-agentmight not seem like the wisest anymore :) We’ll see how receptive their maintainers are to our patches – so far, none of the issues discovered should be fundamentally in conflict with the packages’ design philosophy.Description
Open Questions
Checklist