Skip to content

Conversation

addaleax
Copy link
Collaborator

@addaleax addaleax commented Sep 5, 2024

This is unfortunately very obvious in retrospect 😞

@addaleax addaleax changed the title fix(devtools-proxy-support): handle special characters in proxy URL correctly COMPASS-8254 fix(devtools-proxy-support): handle special characters in SSH URL correctly COMPASS-8254 Sep 5, 2024
host: sshConnectConfig.host,
port: sshConnectConfig.port,
password: !!sshConnectConfig.passphrase,
password: !!sshConnectConfig.password,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭

Copy link
Collaborator Author

@addaleax addaleax Sep 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be fair, this bit is unrelated to the bug itself, but still, yeah, not my smartest move 😅

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I see now it is just in a logging event 👍

readyTimeout: 20000,
keepaliveInterval: 20000,
host: this.url.hostname,
host: decodeURIComponent(this.url.hostname),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see how this would be easy to miss.

@addaleax addaleax merged commit 7592cfc into main Sep 5, 2024
5 checks passed
@addaleax addaleax deleted the 8254-dev branch September 5, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants