feat(mongodb-log-writer): move mongodb-log-writer into devtools-shared MONGOSH-1991 #498
Conversation
This also includes slight refactoring to split the modules of MongoLogManager and MongoLogWriter and export them separately as well as a minor breaking change capitalization typo fix.
gagik
force-pushed
the
gagik/move-logging
branch
from
85d81de to
807ccb1
Compare
gagik
force-pushed
the
gagik/move-logging
branch
from
807ccb1 to
b3da7fa
Compare
| @@ -0,0 +1,90 @@ | |||
| { | |||
| "name": "@mongodb-js/mongodb-log-writer", | |||
There was a problem hiding this comment.
Are we moving it under the @mongodb-js/ prefix? originally the package had the mongodb-log-writer namespace. I think we have both namespaces in devtools-shared. Looks like other old packages that were moved to the mono repo didn't add the @mongodb-js/ prefix to their names. cc @addaleax
There was a problem hiding this comment.
Oh my quick impression was that they did get a prefix but you're right, I could preserve the old name, don't have thoughts about this.
The prefix does mean we'd have divergent packages this way but I thought with a breaking change as long as that's communicated to Compass folk would be same effort.
There was a problem hiding this comment.
probably worth preserving the old name just for the NPM history etc.
This also includes slight refactoring to split the modules of MongoLogManager and MongoLogWriter and export them separately as well as a minor breaking change capitalization typo fix.
Breaking Change:
There's one minor breaking change that seemed worth doing since this is a large enough change anyhow. Can revert if not worth it.
MongoLogManager.cleanupOldLogfiles=>MongoLogManager.cleanupOldLogFilesRelated to:
MONGOSH-1992: Split MongoLogWriter and MongoLogManager
MONGOSH-1991: Move logging to devtools-shared