fix(mongodb-log-writer): issues with parallel mongosh executions MONGOSH-1914 #506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
reviewed
Feb 7, 2025
gagik
approved these changes
Feb 10, 2025
…-log-cleanup-issue # Conflicts: # packages/mongodb-log-writer/src/mongo-log-manager.ts
gagik
reviewed
Feb 10, 2025
…-log-cleanup-issue # Conflicts: # packages/mongodb-log-writer/src/mongo-log-manager.ts
addaleax
reviewed
Feb 11, 2025
Co-authored-by: Anna Henningsen <[email protected]>
…as the first thing
addaleax
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Multiple processes may attempt to clean up log files in parallel. A situation can arise where one process tries to read a file that another process has already unlinked. To handle such scenarios, we will catch lstat errors and retry cleaning up to let different processes reach out to different log files.
Checklist