feat: add ts-autocomplete package MONGOSH-2033 #517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lerouxb
changed the title
addaleax
reviewed
Mar 6, 2025
kmruiz
reviewed
Mar 6, 2025
lerouxb
commented
Mar 6, 2025
Co-authored-by: Anna Henningsen <[email protected]>
kmruiz
reviewed
Mar 6, 2025
lerouxb
force-pushed
the
add-autocomplete-package
branch
from
4160f3d to
e36df0d
Compare
addaleax
approved these changes
Mar 10, 2025
| if (decl) { | ||
| // decl's children are things like ['a', ':', 'string'] or ['bb', ':', | ||
| // '(p1: number) => void']. So the one at position 2 (zero indexed) is the | ||
| // type. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is extracted from the PoC. It doesn't know anything about what's in the TypeScript files, so should be generically useful.
In the end I added back support for filtering the completions, because while adding more tests I noticed there are just tons of cases where it returns the entire global scope or at least adds the entire global scope to the results. So I'm finding it hard to imagine us ever using this without at least some filtering of some kind.