Skip to content

fix: tweak native-machine-id scripts #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 6, 2025
Merged

fix: tweak native-machine-id scripts #536

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
21aba4e
fix: tweak native-machine-id scripts
nirinchev May 6, 2025
ce185d9
add prettier script
nirinchev May 6, 2025
49fc267
Merge branch 'main' into ni/fix-native-machine-id
nirinchev May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 9 additions & 0 deletions packages/native-machine-id/.depcheckrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
ignores:
- '@mongodb-js/prettier-config-devtools'
- '@mongodb-js/tsconfig-devtools'
- '@types/chai'
- '@types/sinon-chai'
- 'sinon'
- 'node-addon-api'
ignore-patterns:
- 'dist'
6 changes: 4 additions & 2 deletions packages/native-machine-id/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,13 @@
"bootstrap": "npm run compile",
"pretest": "npm run compile",
"install": "node-gyp rebuild",
"typecheck": "tsc --noEmit",
"test": "mocha",
"test-cov": "nyc -x \"**/*.spec.*\" --reporter=lcov --reporter=text --reporter=html npm run test",
"test-ci": "npm run test-cov",
"lint": "eslint . && prettier --check .",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll also want to add prettier as a dev dependency and add a reformat script, I think

"check": "npm run lint && npm run test",
"depcheck": "depcheck",
"check": "npm run typecheck && npm run lint && npm run depcheck",
"prepublishOnly": "npm run compile",
"benchmark": "ts-node scripts/benchmark.ts"
},
Expand Down Expand Up @@ -58,7 +60,7 @@
"eslint": "^7.25.0",
"gen-esm-wrapper": "^1.1.1",
"mocha": "^8.4.0",
"chai": "^4.5.0",
"depcheck": "^1.4.7",
"node-machine-id": "^1.1.12",
"typescript": "^5.0.4",
"ts-node": "^10.9.2"
Expand Down
Loading