chore: make node 18 support never end (for test purposes) #537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lerouxb
changed the title
nirinchev
approved these changes
May 7, 2025
kmruiz
approved these changes
May 7, 2025
mcasimir
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a stubbed node.js release schedule file that says that node 18 support ends 30 april. This is true. But the tests use v18 all over the place to test against CVEs with several other test fixtures. We can change all those test fixtures and then all the tests that depend on it OR we can just tweak the support test fixture. And since every network call is already stubbed anyway, I know which one I'm preferring..