feat(devtools-connect): bump oidc-plugin to 2.0.0 MONGOSH-2194 #560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
commented
Jul 4, 2025
| ...clientOptions.oidc, | ||
| ...addToOIDCPluginHttpOptions(clientOptions.oidc, { | ||
| agent: proxyAgent, | ||
| }), |
There was a problem hiding this comment.
This is becoming necessary because [email protected] only accepts a custom fetch, not custom HTTP options (which can more easily extended by adding more options to the object), so aggregating all options into a single place for creating the fetch function has to happen elsewhere. Doing it here and expanding applyProxyToOIDC to also accept a DevtoolsProxyOptions object allows us to keep doing pretty much the same thing when using this in Compass that we do now (maybe even slightly simplify).
lerouxb
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Open Questions
Checklist