fix(mongodb-runner): make close operation more resilient #571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Store identifying information about a server in a database, then only actually run `process.kill()` on servers where this identifying information matches what we expect it to match. Also, do not kill processes to which we cannot connect, and instead assume they have already been closed before. Fixes: #483
gagik
approved these changes
Sep 11, 2025
| const client = await MongoClient.connect( | ||
| `mongodb://${this.hostport}/?directConnection=true`, | ||
| // directConnection + retryWrites let us write to `local` db on secondaries | ||
| `mongodb://${this.hostport}/?directConnection=true&retryWrites=false`, |
There was a problem hiding this comment.
can retryWrites end up messing with our tests?
There was a problem hiding this comment.
Hm ... how would it do that? I can't think of a place where we would even make use of this client. It is a public API, to be fair, but where we do use the withClient() feature, I'm pretty sure we do that on the MongoCluster level, not the MongoServer level
There was a problem hiding this comment.
ah yeah, I was thinking that we were interfacing with it through this client somehow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store identifying information about a server in a database, then only actually run
process.kill()on servers where this identifying information matches what we expect it to match.Also, do not kill processes to which we cannot connect, and instead assume they have already been closed before.
Fixes: #483
Description
Open Questions
Checklist