feat(mongodb-ns)!: move ns package #572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnjackweir
commented
Sep 17, 2025
addaleax
approved these changes
Sep 17, 2025
addaleax
reviewed
Sep 17, 2025
addaleax
approved these changes
Sep 17, 2025
johnjackweir
changed the title
johnjackweir
changed the title
addaleax
reviewed
Sep 17, 2025
There was a problem hiding this comment.
Btw, just for a bit of additional context, Neal pointed out the license change to me. This should be fine as long as all external contributors have signed the CLA as verifiable via https://contributors.corp.mongodb.com/ (and that, in fact, is a big reason of why we have CLAs) – in this case I've manually verified that there are no external contributors, so this is a non-issue entirely 👍 Still makes sense to tag this as a feat! though.
nbbeeken
approved these changes
Sep 17, 2025
nbbeeken
requested changes
Sep 17, 2025
Co-authored-by: Neal Beeken <[email protected]>
nbbeeken
approved these changes
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the https://github.com/mongodb-js/ns package into here where it belongs
Major version bump for license change