fix(mongodb-constants): update NumberLong template to include quotes around value #596
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Nov 17, 2025
Anemy
deleted the
update-number-long-constant-auto-complete-to-be-a-string
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This snippet is used in the CodeMirror editors in Compass.
We want to remove the chance of folks querying in Compass with numbers >
Number.MAX_SAFE_INTEGERwithNumberLongorNumberDecimalwithout quotes.NumberDecimalalready has quotes in the snippet.NumberLong(900719925474099999)vsNumberLong('900719925474099999')This is a fix towards making tickets like COMPASS-8475 COMPASS-7891 COMPASS-8719 less likely to happen. To really fix the issue it'll require some separate changes on the Compass side.