feature/COMPASS-9655 add getCoordinatesForNewNode #110
+178
−97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paula-stacho
force-pushed
the
COMPASS-9655
branch
from
3a6ae27 to
a33d713
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Splitting the logic of
addNodesWithinBounds, so that we can get a position only for single node. We'll need this the functionality of adding a new collection to the diagram (We could use the original function, but then we'd either have to search through the existing nodes or count on the new one being at the end).Notes for Reviewers
📸 Screenshots/Screencasts
Before
After